search

mx3m / hikari-for-jekyll

An open-source theme for Jekyll
http://mx3m.github.io/hikari-for-jekyll
MIT License
235 stars 86 forks source link

Be consistent with social link generation #34

Closed msisto closed 9 years ago

msisto commented 9 years ago

Love the theme.

I noticed that the way Twitter links are constructed in default.html was different than Github, Dribbble and Instagram links:

default.html expects site.twitter to contain only your Twitter handle, where site.github, site.dribbble and site.instagram are expected to be complete URL strings.

This pull changes this so that the template only requires a handle.

ssorallen commented 9 years ago

All 3 sites, Dribbble, GitHub, and Instagram, are served over HTTPS. Can you change the links to https:? It saves the user a redirect from http -> https when they click the link.

And while you're there, would you change the Twitter link as well to https?

msisto commented 9 years ago

Good point. Incoming ...

msisto commented 9 years ago

@ssorallen All set with https:.

ssorallen commented 9 years ago

Great, thanks for the changes. :+1: