mxaddict / mmaker

MMaker is a Market Making trading bot
https://github.com/mxaddict/mmaker
MIT License
30 stars 10 forks source link

how to change the exchange for the algo? #4

Closed nateflanders closed 4 years ago

nateflanders commented 5 years ago

You mentioned in the readme how binance is currently default, but any exchange within CCXT can be connected.

Do you have any instruction on that change within your code?

Looking to connect Bitmex.

Sorry if noob question. Just need direction as to where to start, and I'll be off to the races.

Thanks!

@mxaddict

nateflanders commented 5 years ago

nvm found the config to change bitmex params and currency to BTC/USD rather than what I assumed XBT/USD

However, getting the error when running:

` [InvalidOrder] bitmex {"error":{"message":"orderQty is invalid","name":"HTTPError"}}

                       at handleErrors   ccxt/js/bitmex.js:1233            throw new exact[message] (feedback);                                            
                       at then           ccxt/js/base/Exchange.js:628      this.handleErrors (response.status, response.statusText, url, method, responseH…
                       at _tickCallback  internal/process/next_tick.js:68                                                                         `

Am I going to go line by line in the engine.js file under src to match mex calls?

If not, do you have any guidance here?

Thank you @mxaddict

mxaddict commented 5 years ago

nvm found the config to change bitmex params and currency to BTC/USD rather than what I assumed XBT/USD

However, getting the error when running:

` [InvalidOrder] bitmex {"error":{"message":"orderQty is invalid","name":"HTTPError"}}

                       at handleErrors   ccxt/js/bitmex.js:1233            throw new exact[message] (feedback);                                            
                       at then           ccxt/js/base/Exchange.js:628      this.handleErrors (response.status, response.statusText, url, method, responseH…
                       at _tickCallback  internal/process/next_tick.js:68                                                                         `

Am I going to go line by line in the engine.js file under src to match mex calls?

If not, do you have any guidance here?

Thank you @mxaddict

I think if I remember correctly there were some API calls that I updated/added that were no longer cross exchange and need to be refactored to work with other exchanges.

mxaddict commented 5 years ago

@nateflanders let's continue discussion of #5 on this issue as they are related.

mxaddict commented 5 years ago

I'll see if I can update the API calls to be cross exchange again, not sure if it's worth the effort though.

I was planning on revamping the entire code base for this project.