search

mxck / react-native-material-menu

Pure JavaScript material menu component for React Native
MIT License
512 stars 91 forks source link

Enable the onHidden callback even for iOS #96

Closed lucipacurar closed 3 years ago

lucipacurar commented 3 years ago

I couldn't find exactly why this was disabled, but I enabled it back. It works fine on RN 0.63.

michaelmoney commented 3 years ago

I have same issue on version 1.1.0. The onHidden callback on iOS it's not triggered when menu is dismissed... This PR should fix that, but not sure why this condition was added in the first place.

ZGennadiy commented 3 years ago

I had tested working without that condition and it works well

mxck commented 3 years ago

Hi, everyone! Isn't this.props.onHidden called right here? Previously there was a different behavior on the android and iOS, so this prop was called in different places.

watnFoehn commented 3 years ago

I just put a console.log on my onHidden, while it get's called on Android, it's not getting called on iOS 🤷‍♂️

mxck commented 3 years ago

I just put a console.log on my onHidden, while it get's called on Android, it's not getting called on iOS 🤷‍♂️

Ok. I will check this today.

mxck commented 3 years ago

Fixed in https://github.com/mxck/react-native-material-menu/commit/84209fc06834ecbf3e65fcbf7b6778d1ac0bb83f