mxcl / Path.swift

Delightful, robust, cross-platform and chainable file-pathing functions.
The Unlicense
946 stars 36 forks source link

Make filename Windows-friendly #91

Closed dkolas closed 12 months ago

dkolas commented 12 months ago

Rename Path->Bool.swift to PathToBool.swift

I'm trying to build our project on swift in native Windows for the first time, and when the package manager tries to fetch the package, it chokes on this filename.

mxcl commented 12 months ago

Fixed, but I don’t expect this to work on Windows since we expect / paths and I don't think anyone has corrected that.

dkolas commented 12 months ago

Interesting, thanks! I'll let you know how it goes.

mxcl commented 12 months ago

I recently ported this to TypeScript and made it work on Windows, it isn’t too tricky TBH.

dkolas commented 12 months ago

Cool, thanks. Will put up a PR if/when I get there. Looks like at least one of our other deps doesn't even build on Windows, so having things actually work will be the step after that :)