search

mxcl / PromiseKit

Promises for Swift & ObjC.
MIT License
14.24k stars 1.46k forks source link

Fix #1332 #1342

Closed RomanPodymov closed 6 months ago

RomanPodymov commented 7 months ago

Hello. Thank you for PromiseKit. Fix #1332.

mxcl commented 6 months ago

Is this ready?

RomanPodymov commented 6 months ago

Is this ready?

Hello @mxcl Not yet, SPM is failing. Or maybe I can fix SPM later.

RomanPodymov commented 6 months ago

Is this ready?

Now it's ready.

jayeshkawli commented 6 months ago

@RomanPodymov Thank you for the fix. Much appreciated. Can we also make a release so that we can update our dependencies?

RomanPodymov commented 6 months ago

Hello @jayeshkawli Can you reproduce the issue using master branch? Currently I don't have any project with PromiseKit that I can upload to TestFlight.

jayeshkawli commented 6 months ago

Hello @jayeshkawli Can you reproduce the issue using master branch? Currently I don't have any project with PromiseKit that I can upload to TestFlight.

I am not sure what you mean, can you please elaborate? To my original question, I meant making a next release like from this page https://github.com/mxcl/PromiseKit/releases so that we can fetch this change through SPM/Cocoapods. Or I can also do that if I have necessary permissions.