search

mxcl / Workbench

Seamless, automatic, “dotfile” sync to iCloud.
Other
669 stars 10 forks source link

⌘+drag not working #16

Closed jariz closed 5 years ago

jariz commented 5 years ago

Hiya, great tool! However, not that keen on having it in my menubar at all times. Bartender can't seem to control it, however.

Are you doing something non-standard or something? Haven't really ran into any apps that bartender can't handle.

mxcl commented 5 years ago

We’re not doing anything non-standard.

If the Bartender developers want to investigate, our sources are available for them to read.

jariz commented 5 years ago

I'll shoot them a message, thanks.

bensurtees commented 5 years ago

Hi, I am the developer of Bartender, the issue is that Bartender uses the macOS default behaviour of ⌘+dragging menu items to reposition/order them in the menu bar (try this on other menu items, they should drag and reposition themselves, except Notification Center which isn't allowed to move). This does not work with workbench (regardless of Bartender running) this is because in workbench you are overriding this behaviour by catching events before they go through the StatusItemWindow sendEvent (which handles this) by using a localeventmonitor (which gets the events first), which is okay, but you just want to check to see if ⌘ is pressed (check the event. modifierFlags) and allow that event to pass through (return event) without triggering self?.onStatusBarItemClicked() You should then get the dragging behaviour back, and as an added bonus Bartender will work with it.

Let me know if you need more info or anything.

Ben

bensurtees commented 5 years ago

I created a pull request with what I believe should be a fix ( I didn't compile workbench to test it)

mxcl commented 5 years ago

My bad, we were doing something non-standard. New build on its way.

mxcl commented 5 years ago

Workbench 1.0.1 is available and I have confirmed you can now ⌘-drag.

To force an update hold ⌥ and click the cog menu, the item “Check for updates” will appear. The new version will download and restart, you can verify the version is 1.0.1 by looking in the bottom left of the popup.