search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
13 stars 53 forks source link

add type checker to pre-commit/CI #1053

Open elmjag opened 1 month ago

elmjag commented 1 month ago

It would nice to include a type checking tools to our pre-commit/CI checks.

@marcus-oscarsson suggest using pyright: https://github.com/microsoft/pyright

Another option is of cause the classical mypy: https://mypy-lang.org/

fabcor-maxiv commented 1 month ago

I have used mypy only, never pyright or any other type checking tool. So I believe that I can be reasonably helpful with mypy, but I am perfectly fine with using something else.

And yes, I am for the introduction of some type checker tool.