search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
13 stars 53 forks source link

Clarify contribution guidelines for units #1064

Closed fabcor-maxiv closed 4 weeks ago

fabcor-maxiv commented 4 weeks ago

Here is the preview: https://mxcubecore--1064.org.readthedocs.build/en/1064/dev/contributing.html#units.

fabcor-maxiv commented 4 weeks ago

Here is my attempt at clarifying the contribution guidelines for units...

fabcor-maxiv commented 4 weeks ago

Are we sure about "translative motors" and "rotative motors"? Isn't it rather translational and rotational?

fabcor-maxiv commented 4 weeks ago

Here is the preview: https://mxcubecore--1064.org.readthedocs.build/en/1064/dev/contributing.html#units.

rhfogh commented 4 weeks ago

An additional change, while you are at it . In (or close to) line 195, teh sentende "Contained HardwareObjects also use properties" should probably be removed in the light of yaml configuration.

marcus-oscarsson commented 4 weeks ago

Looks good :), you can merge when the discussed updates have been made. (Ill be away for the rest of the week :))

fabcor-maxiv commented 4 weeks ago

In (or close to) line 195, teh sentende "Contained HardwareObjects also use properties" should probably be removed in the light of yaml configuration.

I guess this should be done on the YAML branch then