search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
13 stars 53 forks source link

Refactoring ISPyBClientMockup for authnentication tests #1066

Closed dominikatrojanowska closed 3 weeks ago

dominikatrojanowska commented 3 weeks ago

The PR is dependent on this one. The change provided here allows to perform correctly authentication tests that are using CREDENTIALS_1: https://github.com/mxcube/mxcubeweb/blob/develop/test/test_authn.py#L24

marcus-oscarsson commented 3 weeks ago

Thanks

marcus-oscarsson commented 3 weeks ago

I'm sorry guys but there is an issue with this code:

get_proposal at this line https://github.com/mxcube/mxcubecore/pull/1066/files#diff-49fa365d70805e215a94138cdd0f725d690114c71b0c7cf53e1ab6d10d055e5fR125 will always return the same proposal regardless of login used.

Hence logging-in with idtest1 returns the proposal of idtest0, right ? This means that the tests for mxcubeweb will fail. If you agree I will disable this test in mxcubeweb for the moment and then you can have a closer look at returning the right proposal (when you get some time)