search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
13 stars 53 forks source link

Use types from typing for Type Hints #1070

Closed walesch-yan closed 3 weeks ago

walesch-yan commented 3 weeks ago

In #1065, I mistakenly added Type hints that use the built-in tuple type, which is introduced in Python 3.9 and hence not supported in Python 3.8. I replaced these and some other instances I found in the code by the corresponding types from typing.

This mismatch seems to be a reason for a failing test in the web version mxcube/mxcubeweb#1483

marcus-oscarsson commented 3 weeks ago

Nice, well done :)

rhfogh commented 3 weeks ago

One more reason to upgrade to a newer minimum Python.