mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 52 forks source link

Fix Error in keV-A conversion #744

Closed rhfogh closed 1 year ago

rhfogh commented 1 year ago

The main part of this PR is a bug fix - the HC_OVER_E conversion constant between A and keV was WRONG by a factor of 10. It was calculated at hc10e6/e, missing the point that this point gives the conversion between nm and keV, whereas we want it in A.

I am very surprised that this problem has never been noticed - I can only assume that 1) mxcubecore is not yet heavily used, 2) conversion from A to energy and back again does not show the problem or 3) the conversion factor is often not used. Anyway, if someone could double check that the new value is correct and whether it gives errors somewhere it would be lovely.

The rest of the changes are WIP progress in refactoring teh GPhL user interface.