search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 52 forks source link

Added additional test cases to cover command container classes #759

Closed oldfielj-ansto closed 1 year ago

oldfielj-ansto commented 1 year ago

Even more test cases to cover command container classes, I've also added type hinting for these classes where possible. Getting fairly close to having all the base classes covered by test cases.

There are some areas where full test coverage couldn't be achieved, some of the methods may need to be refactored before we can get to 100% coverage. I also ran into some areas of code where there seem to be missing imports, these might be present when MXCuBE-Web is also installed.

marcus-oscarsson commented 1 year ago

@oldfielj-ansto thanks !. Ill have a closer look during the day. Looks really nice from a first look :+1:

marcus-oscarsson commented 1 year ago

Thanks ! Looks like there are some issues with the GitHub Virutal machine/env again, seems to be come and go somehow. Does anyone know what this is ?