mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 52 forks source link

AbstractCharacterisation is broken #784

Open rhfogh opened 12 months ago

rhfogh commented 12 months ago

Lookiing at both EDNACharacterisation, and P11EDNACharacterisation, it seems that neither follows the rules of their superclass, AbstractCharacterisation. There are several function signatures in the subclasses that do not follow those in the superclass. In theory the superclass definitions should always take precedence, but in this case it looks like maybe the abstract superclass should be modified to conform to the working implementations.

Anyway, could someone who uses EDNACharacterisation take at look at harmonising this?