Fix login issues in ISPyB clients (and mockups)

mxcube / mxcubecore

Backend used by MXCuBE

http://mxcube.github.io/mxcube/

GNU Lesser General Public License v3.0

11 stars 52 forks source link

Fix login issues in ISPyB clients (and mockups) #793

Closed fabcor-maxiv closed 11 months ago

fabcor-maxiv commented 11 months ago

For test purposes ISPyBRestClientMockup should fail authentication when the password is wrong. Also there were multiple ways to access the "login type" value, that were not always in sync. The one true way should be to go through get_property("loginType").

GitHub: relates to https://github.com/mxcube/mxcubeweb/issues/1045 GitHub: relates to https://github.com/mxcube/mxcubeweb/pull/1049

marcus-oscarsson commented 11 months ago

Thanks :)

marcus-oscarsson commented 11 months ago

Looks good to me, we will try to follow up with another PR to take care of loginType and etc (feel free to give it go if you feel inspired :) ).

fabcor-maxiv commented 11 months ago

Thanks all for the reviews.

I think I have addressed what can/should be addressed within this pull request. I think it is ready for merge :)

marcus-oscarsson commented 11 months ago

Cool, thanks