Closed fabcor-maxiv closed 11 months ago
Thanks :)
Looks good to me, we will try to follow up with another PR to take care of loginType
and etc (feel free to give it go if you feel inspired :) ).
Thanks all for the reviews.
I think I have addressed what can/should be addressed within this pull request. I think it is ready for merge :)
Cool, thanks
For test purposes
ISPyBRestClientMockup
should fail authentication when the password iswrong
. Also there were multiple ways to access the "login type" value, that were not always in sync. The one true way should be to go throughget_property("loginType")
.GitHub: relates to https://github.com/mxcube/mxcubeweb/issues/1045 GitHub: relates to https://github.com/mxcube/mxcubeweb/pull/1049