Introduced AbstractAuthenticator

mxcube / mxcubecore

Backend used by MXCuBE

http://mxcube.github.io/mxcube/

GNU Lesser General Public License v3.0

11 stars 51 forks source link

Introduced AbstractAuthenticator #829

Closed marcus-oscarsson closed 7 months ago

marcus-oscarsson commented 7 months ago

Greetings from the MXCuBE meeting :)

Introduced AbstractAuthenticator and made necessary updates to LdapLogin

This also means that we should move the authenticate call from ISPyBclient to the the authenticate/login logic.

All *LdapLogin classes have been updated so that they care now call *Authenticator

marcus-oscarsson commented 7 months ago

So, now with the syntax fix for the ISPyBClient

github-actions[bot] commented 7 months ago

Coverage Report •

File	Stmts	Miss	Cover	Missing
mxcubecore/HardwareObjects
ISPyBClient.py	1344	1344	0%	1–2585
TOTAL	60633	56149	7%

Tests	Skipped	Failures	Errors	Time
1925	0 :zzz:	0 :x:	0 :fire:	1m 34s :stopwatch:

fabcor-maxiv commented 7 months ago

I do not understand what is going on with the pull requests now :D

Why is this new pull request not on top of develop (i.e. on top of the revert of the previous one)?

fabcor-maxiv commented 7 months ago

By the way, indeed it was a syntax error, thanks for the fix :)

marcus-oscarsson commented 7 months ago

@fabcor-maxiv, yes as you noticed that there was a syntax error, I thought it was better to revert the PR and then add the fix. There's been sometime since I created the PR and I forgot that I also needed to also test with the ISPyBClient and not only ISPyBClientMockup.