Closed elmjag closed 5 months ago
Is it possible to drop ispyb-client from mxcubecore depencies? Is it used a lot?
Or, can we update ispyb-client to work with typing_extensions >= 4.9.0?
Who maintains this package now? Its pypi page does not say a lot: https://pypi.org/project/ispyb-client/
My guess is that ispyb-client
has been automatically generated. See: https://inspector.pypi.io/project/ispyb-client/1.0.0/packages/9e/8e/6e22b10f96b12053084532cf3269e19b06bde98b99224bfa91aea2d3a8ac/ispyb_client-1.0.0.tar.gz/ispyb_client-1.0.0/setup.py
Ispyb is in some kind of limbo right now. I think I now do have some permissions on some GitHub repositories, but not enough permissions to do anything significant.
ispyb-client
is indeed automatically generated and is now now longer used. It was used for a brief moment but since then other decisions have been made making at-least as it is now ispyb-client
deprecated. It can safely be removed from the dependencies.
Aha! I'll make a PR to remove ispyb-client
!
If sqlalchemy 2.0.25 package is installed, mxcube will fail to start with this error message:
The problem is that
sqlalchemy
2.0.25 requirestyping_extensions
>= 4.9.0.However, it's not possible to install that version of
typing_extensions
. This is due to another transient dependency totyping_extensions
package viaispyb-client
package.Ispyb-client
have a pinned dependency ontyping_extensions
4.3.0. Mxcubecore is already using latest version ofispyb-client
.