search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 52 forks source link

Update Python version for the `pre-commit` hooks #844

Closed fabcor-maxiv closed 8 months ago

fabcor-maxiv commented 8 months ago

Since the Python range is >=3.8,<3.11 in conda-environment.yml (and in the Poetry config in pyproject.toml as well), the version installed by default will be Python 3.10.

It makes sense to use the same version in the pre-commit hooks.

GitHub: fix https://github.com/mxcube/mxcubecore/issues/836

marcus-oscarsson commented 8 months ago

I agree with @rhfogh and as I said previously if I'm not mistaken the pre-commit scripts runs in a separate environment specified by the pre-commit config file so it should not be effected by what's in the conda environment. That is also why I previously asked what the exact problem was so that we can deal with it correctly.

Edit: I might of-course be mistaken and there is a Python version issue to deal with but it then becomes a bit more complicated for the reason @rhfogh highlights above, but we need to know what the issue was.