search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

[WIP] P11 develop upgrade #854

Closed agruzinov closed 4 months ago

agruzinov commented 4 months ago

Here is a repeat of PR 800, hopefully without rebase issues and updated to the current state.

beteva commented 4 months ago

Hi @agruzinov. The DESY specific hardware objects look fine to me. Maybe additional cleaning could be to use super(). instead of super(classname, self), but this depends on you. I am concerned about the recursion you mention and find important to understand why and where it happens. Also thanks to you changing the Beamline.py, we've spotted a bug, which is very unlikely to happen, but still it is nice to have a clean code. I would not merge yet the PR, until we understand the recursion problem.

agruzinov commented 4 months ago

Thanks everyone for the review and comments. Would it make sense to split this PR now into HO/DESY part and abstract ones since DESY specific hardware objects are ok for everyone?

Digging into recursion problem might take more time.

beteva commented 4 months ago

Yes, @agruzinov, very good idea. We could merge your local HO and than try to find the origin of the recursion and the problem with the sample changer

marcus-oscarsson commented 4 months ago

@agruzinov, did I understand you correctly, that you wanted to close this PR ?

agruzinov commented 4 months ago

Yes, as soon as #859 will be merged. I've manually merged all the HO objects, so no-one need to go through >160 commits in the history.

marcus-oscarsson commented 4 months ago

:), thanks thats thoughtfull of you ;)

agruzinov commented 4 months ago

This PR was split to two (PR856, 859) as discussed. Closing.