search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

Updated versions of DESY P11 HO (PR 800, 854) #856

Closed agruzinov closed 4 months ago

agruzinov commented 4 months ago

As discussed in PR 800/854 here is the DESY P11 HO objects cumulative PR.

beteva commented 4 months ago

Hi @agruzinov, all looks fine for me. Thanks for the effort. I will wait for another day if somebody has anything to say and will merge the PR.

marcus-oscarsson commented 4 months ago

Looks good to me, just a few comments.

marcus-oscarsson commented 4 months ago

The linting step is failing, Ill merge when its fixed :). Thanks !

agruzinov commented 4 months ago

black and autopep8 are ran on the code but it is not yet happy still... What could it be?

fabcor-maxiv commented 4 months ago

black and autopep8 are ran on the code but it is not yet happy still... What could it be?

Autoflake: https://github.com/mxcube/mxcubecore/actions/runs/8063131751/job/22024333705?pr=856#step:6:29

You should be able to run pre-commit run locally.

marcus-oscarsson commented 4 months ago

@agruzinov do the follwing in your shell pre-commit run --all-files then check the changes with git gui and commit the updates.

marcus-oscarsson commented 4 months ago

Great ! :+1: