search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

refactoring get_objects_by_role() in HardwareObjectNode class #857

Closed HilbertCorsair closed 4 months ago

HilbertCorsair commented 4 months ago

This is the refactoring that was discused in my previous PR. This new PR should eliminate the coplications of the previous atempt.

marcus-oscarsson commented 4 months ago

Thanks, its a clear improvement very nice :+1:

There seems to be some linting errors. Apart from that it would be really nice with a test case for this, especially since its a very frequently used piece of code and also because it might get changed when we start working on the xml to yml work.

fabcor-maxiv commented 4 months ago

Some of the linting issues are unrelated to this pull request, so I fixed them here: https://github.com/mxcube/mxcubecore/pull/858

marcus-oscarsson commented 4 months ago

@rhfogh I think there were still some linting not passing, no problem of fixing them in a follow up PR though.

rhfogh commented 4 months ago

Sorry, I guess I jumped the gun there

marcus-oscarsson commented 4 months ago

Oh wow, working late :). No problem, I think it happened a few times already and it should be easy enough to fix :) What I think Ill do is to enable the option that blocks merging if the pipeline is failing. However it means that we need to disable the test coverage step for now.

I'm on vacation until Monday, so It has to wait for next week.

rhfogh commented 4 months ago

If we start insisting on the pipelines succeeding, then I guess someone would have to help me with mine - it seems to fail every time for my pushes and has never worked as far as I know. But lots of time to look at that later.