mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

New XRF implementation #860

Closed beteva closed 2 months ago

beteva commented 4 months ago
beteva commented 4 months ago

WIP as testing not finished yet.

github-actions[bot] commented 4 months ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
mxcubecore/HardwareObjects/abstract
   AbstractXRFSpectrum.py1201786%64, 97–98, 131–136, 141, 179–181, 225–229
mxcubecore/HardwareObjects/mockup
   XRFSpectrumMockup.py10190%44
mxcubecore/queue_entry
   xrf_spectrum.py59590%19–136
TOTAL60678560198% 

Tests Skipped Failures Errors Time
1933 0 :zzz: 0 :x: 0 :fire: 1m 36s :stopwatch:
meguiraun commented 4 months ago

will try to test this in the beamline next week, on a quick look it looks good!

beteva commented 4 months ago

Thanks @meguiraun. For information it works on the ESRF beamlines.

marcus-oscarsson commented 3 months ago

ok, looks fine to me then. We can follow up with a PR for the signal documentation and perhaps eventually something with a model instead of the dictionary for the ISPyB values