search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

Beam definer #872

Open meguiraun opened 3 months ago

meguiraun commented 3 months ago

working with beam finer elements:

marcus-oscarsson commented 3 months ago

@meguiraun: Are you ready with this one ?

marcus-oscarsson commented 2 months ago

Very nice initiate :) :+1: I made some minor comments you might want to have a look at

beteva commented 1 month ago

@meguiraun I like your idea of introducing a beam definer. Thus we could make an abstraction of what is the hardware, that defines the beam size. This also simplifies the code as there is no more need of the evaluate_beam function, as get_beam_size will give the beam size of whatever the definer is. It is a good idea to provide handling of aperture and slits, but than I believe they should be configured as beam definer.