search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

Conformance to AbstractMulticollect #890

Closed marcus-oscarsson closed 3 weeks ago

marcus-oscarsson commented 3 months ago

@rhfogh pointed out the following in PR #877. AbstractMulticollect is under a long going review and refactoring so this might well be dealt with when that is finished however some of this might be worth to look at before that is done

MultiCollectMockup:

Does not implement all abstract methods.
start_acquisition does not match superclass function parameters.

AbstractMultiCollect:

calls to last_image_saved do not match parameters in function definition

ESRFMultiCollect:

Does not implement all abstract methods.
Definition of last_image_saved do not match superclass function def

LNLSCollect:

Does not implement all abstract methods.
signature of start_acquisition does not match superclass