search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

bring back 'Ring Current' widget in mocked beamline #916

Closed elmjag closed 2 months ago

elmjag commented 2 months ago

Emit 'valueChanged' signal when mocked Machine Info state changes. Seems that 'machInfoChanged' signal have been replaced depricated in favour of 'valueChanged'.

This brings back 'Ring Current' widget when running MXCuBE agains the mocked beamline.

Also, fixes some typos in the docs string.

beteva commented 2 months ago

Thanks for cleaning up If we apply the rule we have (get/set_value and valueChanged for the attribute which is in the name of the file, indeed MachineInfo should emit valueChanged. I guess we should also implement get_value that gives back a dictionary with the relevant keys

beteva commented 2 months ago

Thanks for cleaning up If we apply the rule we have (get/set_value and valueChanged for the attribute which is in the name of the file, indeed MachineInfo should emit valueChanged. I guess we should also implement get_value that gives back a dictionary with the relevant keys

elmjag commented 2 months ago

I guess we should also implement get_value that gives back a dictionary with the relevant keys

Looking at AbstractMachineInfo class, get_value() does not seems to be the part of the API for MachineInfo hardware objects. Is there any code that wants to call get_value() method on MachineInfo hardware objects?

beteva commented 2 months ago

Is there any code that wants to call get_value() method on MachineInfo hardware objects?

Actually not yet, but I believe we have to got through the whole chain HO-adapter to make it more consistent. I was looking at the AbstractMachibeinfo and think that we need to implement get_value() method and emit the right signal (valueCjanged) if we want to be sure that it does not depend on the local HO only.. I suggest to merge this PR as it is and, if you do not mind, I'll take over to make more "standard" MachineInfo chain (I've actually started the implementation for testing mostly)

elmjag commented 2 months ago

I suggest to merge this PR as it is and, if you do not mind, I'll take over to make more "standard" MachineInfo chain (I've actually started the implementation for testing mostly)

Yes, feel free to merge this and it would be much appreciated can refactor MachineInfo suff!