Closed beteva closed 2 months ago
Not sure I like 'get_value' for this class. get_value is defined for an AbstractActuator, which actually has a single value that follows from the (name of the) class. Also, those 'values' are generally settable. For what sounds more like a general information dictionary I'd say that a different name would be less confusing.
Not sure I like 'get_value' for this class. get_value is defined for an AbstractActuator, which actually has a single value that follows from the (name of the) class. Also, those 'values' are generally settable. For what sounds more like a general information dictionary I'd say that a different name would be less confusing.
Well, if we consider MachineInfo as an entity, than it has only one value, which happens to be a dictionary. I do not mind renaming the method (something like get_attributes), but than we do not follow the rule get_value corresponds to the class name. I am fine either way.
Thanks, looks good to me :),