mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

Fix usage of deprecated `ruamel.yaml` API #920

Closed fabcor-maxiv closed 2 months ago

fabcor-maxiv commented 2 months ago

Also formatted with black.

fabcor-maxiv commented 2 months ago

I am navigating a bit blindly here. I have no idea if this part of the code still runs, not sure how I would trigger it. Since it did not fail before, for me there is no difference. @rhfogh, the impacted part of the code seems to be related to Gphl workflows so you might have better visibility here.

There is another usage of ruamel.yaml in mxcubecore/HardwareRepository.py but it seems to already conform to the new API.

fabcor-maxiv commented 2 months ago

One question: There is also an import yaml in HardwareObjects.StateMachine. Should that also be modified?

Oh! Wow! ... That is another weird one... New ticket, to discuss this: https://github.com/mxcube/mxcubecore/issues/921