In my environment, import yaml imports the yaml import package installed by the PyYaml distribution package. But PyYAML is not declared as direct dependency in pyproject.toml, which is a bad thing. Obviously, all direct dependencies (the things we import directly) should all be declared in pyproject.toml.
In my environment, it happens that PyYAML is installed as a dependency of pre-commit (and also Sphinx-related things, but that is relatively new, while pre-commit has been here longer). So things work fine, but...
If we depend on PyYAML, we should declare it so in pyproject.toml.
Maybe we do not need to depend on both Yaml libraries: ruamel.yaml and PyYAML.
@rhfogh wrote:
-- https://github.com/mxcube/mxcubecore/pull/920#pullrequestreview-2009186086
In my environment,
import yamlimports theyamlimport package installed by thePyYamldistribution package. ButPyYAMLis not declared as direct dependency inpyproject.toml, which is a bad thing. Obviously, all direct dependencies (the things we import directly) should all be declared inpyproject.toml.In my environment, it happens that
PyYAMLis installed as a dependency ofpre-commit(and also Sphinx-related things, but that is relatively new, whilepre-commithas been here longer). So things work fine, but...PyYAML, we should declare it so inpyproject.toml.ruamel.yamlandPyYAML.