search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

PyTango no longer optional dependency #927

Closed marcus-oscarsson closed 2 months ago

marcus-oscarsson commented 2 months ago

There are test cases that depend on PyTango and a large majority is using Tango on someway, so the optional flag is a bit unnecessary in my opinoin.

fabcor-maxiv commented 2 months ago

There are test cases that depend on PyTango

Maybe we could fix the pipelines, documentations, and whatnot, to make sure that all optional dependencies are installed before running tests. I guess what I mean is that it probably is not strictly necessary to make it a mandatory dependency. But of course, I am also fine if we make it a mandatory dependency (it is probably less work).

marcus-oscarsson commented 2 months ago

@fabcor-maxiv Yes, I agree that it would make sense if we had alot of dependencies that are more or less exclusive and only used by a few sites but I think it makes less sense for PyTango at least as I see it.