search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

Attempt to solve issue 902 #940

Open marcus-oscarsson opened 2 weeks ago

marcus-oscarsson commented 2 weeks ago

Attempt to resolve #902. If accepted everybody have to update their local configuration files and use <object> instead of <equipment>or <device>

issue 902

fabcor-maxiv commented 2 weeks ago

If accepted everybody have to update their local configuration file and use instead of or

Missing some words here? :D

marcus-oscarsson commented 2 weeks ago

I'm not sure this is the best way to do this; I would suggest that each site goes through their specific files and the common files to check if the proposed changes are alright. Or we can open a PR per site and for common files if its more digestible ?

marcus-oscarsson commented 2 weeks ago

If accepted everybody have to update their local configuration file and use instead of or

Missing some words here? :D

Its the < tags that made the "words" go missing :)

beteva commented 2 weeks ago

There are two aspects of this issue - one is to change everywhere in the python code Device and Equipment inheritance and remove the two classes.The other is to change all the device and equipment to object keyword in the xml files. Agree with @marcus-oscarsson that the local configuration has to be changed by each site. Just to confirm that this can be done even without changing the inheritance in the python files. We've already doing it at ESRF. once this done, we could do in one go the python inheritance,

marcus-oscarsson commented 2 days ago

So what do you think, are we ready to make the jump to Object in this way or is to drastic ?