search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

Lint YAML files with `yamllint` #948

Closed fabcor-maxiv closed 6 days ago

fabcor-maxiv commented 1 week ago

There is now a configuration file for yamllint and a pre-commit hook.

Some of the most straightforward linting issues were fixed. The other ones are ignored and should be handled in the future.

fabcor-maxiv commented 1 week ago

See also https://github.com/mxcube/mxcubeweb/pull/1264

I believe it might be useful to have linting for YAML files, since we are planning to move configuration from XML to YAML.

I made a best effort attempt at fixing some of the linting issues the tool found. For some files I was braver than for others. I focused on the files I know about (meaning pretty much anything but the gphl files). For the remaining linting issues I added ignore rules.

marcus-oscarsson commented 6 days ago

:+1: Thanks, nice initiative :)