search

mxcube / mxcubecore

Backend used by MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
11 stars 51 forks source link

yaml configs: a couple of fixes #949

Closed elmjag closed 2 days ago

elmjag commented 3 days ago

I had to make these two changes to be able to run mxcube-web, wiith mixed XML and YAML config files for HWOs.

It possible it overlaps slightly with https://github.com/mxcube/mxcubecore/pull/936. However, as we decided to post-prone the Pydantic changes for later, I'm putting this here.

marcus-oscarsson commented 3 days ago

Thanks !

marcus-oscarsson commented 3 days ago

The pre-commit is failing for some reason, it does not seem to be files that you changed.

I let you decide exactly how to do, either you merge this as it is and we follow up with a lint fix later or you include in this PR

elmjag commented 2 days ago

The the pre-commit was failing on the original xml_yaml_conversion branch. I was not sure to do about that. I have added commits to fix reported errors.

Now, I see that the tests are failing, I'll take a look at what is going on.

marcus-oscarsson commented 2 days ago

Its ok for the tests I think, its because the syntax in the yml files changed from _class to class and so on

marcus-oscarsson commented 2 days ago

Ill merge this and we will take care of the tests later