search

mxcube / mxcubeqt

Qt Front-end of MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
14 stars 34 forks source link

Rhfogh refactor GPhL UI #446

Closed rhfogh closed 1 year ago

rhfogh commented 1 year ago

Refactored GPhL UI popups (using JsonParamsGui), to be ready for porting to Web version.

Also thoroughly linted and added in-line type annotations.

Since in-line type annotations are a departure from the Google doc strings we normally use, it would be great to see some feedback on the typing style before merging. The in-line annotations are more compact, but give less visual clarity in the function definitions, so we may well want to stick with doc string annotations after all (and I am very willing o change back).

Extensively debugged in mock mode, but because of the magnitude of the change even more testing might be required.

rhfogh commented 1 year ago

Was made to master in error, shoudl have been to develop.