rhfogh
commented
1 year ago That looks fine. And thanks for getting it done so fast, committing from the train is 'above and beyond'.
So after that, develop should be the top branch to keep working on, right? Out of curiosity, Looking at the commit tree, there are a lot of commits registered against agruzinov/p11_qt_update. Are they already included in develop now, through some other branch, or are they awaiting a new PR?
Rasmus
On 08/09/2023 12:11, agruzinov wrote:
You can view, comment on, or merge this pull request online at:https://github.com/mxcube/mxcubeqt/pull/451 https://github.com/mxcube/mxcubeqt/pull/451
Commit Summary
ef1501c https://github.com/mxcube/mxcubeqt/pull/451/commits/ef1501c711510812c263d0812f177e452a84a015 Repeat of PR449 to the dev branch instead of master
File Changes(3 files https://github.com/mxcube/mxcubeqt/pull/451/files)
D mxcubeqt/icons/delete.png https://github.com/mxcube/mxcubeqt/pull/451/files#diff-0c24ec10c07f27ab7e0c93a056e1c86365dc37302a1fb331d1d88bd675acaaff (0)
D mxcubeqt/icons/save.png https://github.com/mxcube/mxcubeqt/pull/451/files#diff-26e5cef43912669d3006fe3c91d69ffa30955a53de2578c28566f4e1d538ae53 (0)
D mxcubeqt/icons/stop.png https://github.com/mxcube/mxcubeqt/pull/451/files#diff-c9bc6483d61fe5ec5812e858abcdafc521bd7658392d40f814a065fba46ad6c7 (0)
Patch Links:https://github.com/mxcube/mxcubeqt/pull/451.patch https://github.com/mxcube/mxcubeqt/pull/451.patch
https://github.com/mxcube/mxcubeqt/pull/451.diff https://github.com/mxcube/mxcubeqt/pull/451.diff
— Reply to this email directly, view it on GitHub https://github.com/mxcube/mxcubeqt/pull/451, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACK5QEAO7UVGHAIK23JHKLTXZL4OLANCNFSM6AAAAAA4QHFCGQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>
agruzinov
OK to merge