search

mxcube / mxcubeqt

Qt Front-end of MXCuBE
http://mxcube.github.io/mxcube/
GNU Lesser General Public License v3.0
14 stars 34 forks source link

[WIP] P11 qt develop 2 #457

Closed agruzinov closed 5 months ago

agruzinov commented 11 months ago

Another round of update to the latest develop. Main add is in confirm_dilalog.py to show N/A in case some of the acquisition parameters are not properly initialized. It helped to track the bug in core in Beamline.py where osc_start was initialized almost always to the "None" because in the beamline_config.yml osc_start was set to 0.0. Changing it to the 0.001 was fixing the problem.

This has also fixed the "red" None value bnox for osc_start in Characterization tab.

BeamSize display was added by Bixente.

rhfogh commented 8 months ago

What is the problem exactly with the red boxes?

I found a bug in Beamline.py that changed osc_start form 0.0 to None - I shall put in a fix for that ASAP. Might that solve some of these problems??

agruzinov commented 8 months ago

I guess it is the same bug in the Beamline.py This might be it.

agruzinov commented 8 months ago

Red boxes are fixed after merging of mxcubecore:#861 indeed, so after all I've started another more cleaner PR #459.

agruzinov commented 5 months ago

Substituted by PR#459. Closing.