Closed elmjag closed 2 weeks ago
@elmjag I did not add all, as wanted to show that you have the choice of not displaying everything. If you need to add all the rest, please do so.
The idea of the mxcubecore PR #917 - Refactor AbstractMachineInfo and the corresponding mxcubeweb PR #1222 was to be able to add as many fields to display as your HO provides. In the current xml file you have already.
<object class="MachineInfoMockup">
<parameters>["current", "lifetime", "dummy"]</parameters>
</object>
The dummy in the parameters list serves "test_check_attributes" in the tests, just to create an error, so, please, do not remove it.
@elmjag, my apologies. I was looking at the wrong xml file - the one on the mxcubecore repository. Anyhow you can add whatever you need. We need, though, to find a way of having the configuration files in just one place, so there is no repetition or worse - inconsistency.
I don't have any strong feelings about this change.
My rationale for adding <parameters/>
tag is that it gives us a nice example of how you can configure MachineInfo hardware objects. I assume that the mock-ups are commonly studied when trying to understand new parts of MXCuBE.
When running MXCuBE with mockups, enable more fields in the machine info drop-down box. Let's include 'message' and 'lifetime' fields in addition to 'current', as the MachineInfoMockup implements these fields.
The result looks like this: