search

mxcube / mxcubeweb

MXCuBE-Web
http://mxcube.github.io/mxcubeweb/
GNU Lesser General Public License v3.0
20 stars 37 forks source link

Lint YAML files with `yamllint` #1264

Closed fabcor-maxiv closed 6 days ago

fabcor-maxiv commented 1 week ago

There is now a configuration file for yamllint and a pre-commit hook.

The most straightforward linting issues were fixed. The other ones are ignored and should be handled in the future.

fabcor-maxiv commented 1 week ago

I started with this because I am planning to do more changes to the pre-commit hooks, and had to first clean up the formatting/linting of the .pre-commit-config.yaml file.

fabcor-maxiv commented 1 week ago

We should also do the same for mxcubecore. Especially since we are planning to migrate all configuration to YAML files.

elmjag commented 6 days ago

+1 for more linting!

fabcor-maxiv commented 6 days ago

From my point of view, this is ready for merge. I hope to get started working on the same change for mxcubecore soon-ish.

marcus-oscarsson commented 6 days ago

Thanks, ok

fabcor-maxiv commented 6 days ago

For mxcubecore: https://github.com/mxcube/mxcubecore/pull/948