mxcube / mxcubeweb

MXCuBE-Web
http://mxcube.github.io/mxcubeweb/
GNU Lesser General Public License v3.0
21 stars 38 forks source link

Remove unused FontAwesome deps and init code #1265

Closed axelboc closed 3 months ago

axelboc commented 3 months ago

There are many, many ways to use FontAwesome. The simplest way, which is used in MXCuBE is to install the @fortawesome/fontawesome-free package and import the @fortawesome/fontawesome-free/css/all.min.css stylesheet. This basically provides a web font with all of FontAwesome's free icons, which can then be used in HTML with <i class="fas fa-cog" />.

This is far from the best way to use FontAwesome since it means all the free icons are loaded even if they're not used, but it has the advantage of being very simple to set up and work with. So I'm not changing it (it would be way to much work anyway).

The problem was that MXCuBE was also kinda trying to set up FontAwesome in two other ways: