search

mxcube / mxcubeweb

MXCuBE-Web
http://mxcube.github.io/mxcubeweb/
GNU Lesser General Public License v3.0
21 stars 38 forks source link

Use lowest supported Python version for checks #1266

Closed fabcor-maxiv closed 3 months ago

fabcor-maxiv commented 3 months ago

We should do formatting, linting, testing, and so on against the lowest Python version that we intend to support. We want to make sure we do not introduce unsupported Python syntax. Because Python is generally backwards-compatible this should be good enough to check against lowest version.

fabcor-maxiv commented 3 months ago

I am quite sure that we discussed this already, likely on mxcubecore, so I was surprised to see it was not the case on mxcubeweb.

fabcor-maxiv commented 3 months ago

In the checks:

build-linux (3.10) Expected — Waiting for status to be reported

I do not understand why, since this pull request replaces it with 3.8. I believe this check should not be run. There is no point in waiting for it to pass. I do not think there is anything to do about this, the pull request is ready for merging from my point of view.

marcus-oscarsson commented 3 months ago

Indeed, thanks !