mxcube / mxcubeweb

MXCuBE-Web
http://mxcube.github.io/mxcubeweb/
GNU Lesser General Public License v3.0
20 stars 37 forks source link

Remove unused deps #1267

Closed axelboc closed 5 days ago

axelboc commented 5 days ago

Fix #1242

All in all, depcheck did a good job :blush: — I did go over all the deps myself just in case it missed one (it didn't). Do please double check thoroughly.

Unused dependencies

Unused devDependencies

Missing dependencies

All of these are direct dependencies of eslint-config-galex, so no need to install them. :green_circle:

fabcor-maxiv commented 5 days ago

Nice job with the investigation! I will try to give it a check from our side, but there is not much doubt you know this stuff better than we do. : )

fabcor-maxiv commented 5 days ago

Could we get a pre-commit hook or maybe a GitHub Action to make sure it stays clean? Would that make sense?

marcus-oscarsson commented 5 days ago

Nice, well done and big thanks !

axelboc commented 5 days ago

Could we get a pre-commit hook or maybe a GitHub Action to make sure it stays clean? Would that make sense?

Hmm, I feel like it would be a bit brittle and not really worth the effort. An unused dependency just adds a few ms to the installation time; nothing worth worrying about too much in my opinion, especially since it doesn't take long to do a bit of a clean-up like this from time to time.