search

mxcube / mxcubeweb

MXCuBE-Web
http://mxcube.github.io/mxcubeweb/
GNU Lesser General Public License v3.0
25 stars 39 forks source link

fix queue_mount_sample() signature #1482

Closed elmjag closed 3 weeks ago

elmjag commented 3 weeks ago

The queue_mount_sample() is now called with 3 arguments, view argument is no longer provided.

The invocation of queue_mount_sample() have been changed in this commit: https://github.com/mxcube/mxcubecore/commit/cb742731c8669149bc5741681f006bf1d0d58823

This change makes mxcubeweb incompatible with older versions of mxcubecore, thus we need to bump mxcubecore version.

This change fixed the pytest tests, when running against latest mxcubecore.

elmjag commented 3 weeks ago

After I made this PR, I noticed this one: https://github.com/mxcube/mxcubeweb/pull/1469

I'm guessing that https://github.com/mxcube/mxcubeweb/pull/1469 also solves the problem with failing tests. However, I was not able to test it, as there is some merge conflict now with latests develop branch.

We should probably merge #1469 rather then this PR. But I'll leave this PR open for now, until we sort out the failing tests.

marcus-oscarsson commented 3 weeks ago

Thanks @elmjag, its indeed meant to be taken care of in #1469. Ill close this for now