search

mxenabled / mx-react-components

A library of generic React components used at MX
MIT License
77 stars 61 forks source link

Drawer header revisions #276

Closed derek-boman closed 8 years ago

derek-boman commented 8 years ago

I've updated the Construction section of the drawer component here: https://app.frontify.com/d/KHQZnlj1XMIO/web-patterns#/components/drawer/construction

This issue is for the header portion of the drawer (see also #274 and #275). There are two general types of drawer headers I've found a need for: one with a large amount and one with action buttons. See Aggro style guide for full specs.

header bar 1 example header bar 1 example copy

cerinman commented 8 years ago

This will also be an internal thing. The OS Drawer component is just the wrapper/title bar so we can't specify this stuff here. Closing, let me know if you have questions.

derek-boman commented 8 years ago

@cerinman good to know. I'd like to make sure that we build this in some kind of reusable manner since it'll be used in different places throughout the app: Transaction Details, Account Details, etc. I want to make it easy to update. From the design side, I see these two header styles as interchangeable molecules in a drawer organism.

How do you typically handle this in the code? Can React nest components?

cerinman commented 8 years ago

Yes, React can nest components with no issues and yes the plan is to make those their own components to make our lives easier.