search

mxew / firetable-user

client side front end for firetable, a virtual music listening room powered by firebase.
https://thompsn.com/log/about/firetable
MIT License
18 stars 8 forks source link

inline image mode strips out the v in .gifv links #91

Open mxew opened 4 years ago

cyancey76 commented 4 years ago

.gifv is supposed to be rendered inline in <video> with a .webm or .mp4 extension. At least with Imgur, stripping off the v should still work as it makes Imgur convert the video to animated gif. @mxew Is there a specific circumstance that the missing v is causing a problem?

mxew commented 4 years ago

I usually have inline images off, but the issue as I understand it is that imgur will often return just a static image for the .gif version. And then since we stripped out the v, even clicking through to the link only shows the static image... causing users to have to switch to the .mp4 link to be able to share that particular video in chat

On Apr 19, 2020, at 1:36 AM, CJ Yancey notifications@github.com wrote:

 .gifv is supposed to be rendered inline in with a .webm or .mp4 extension. At least with Imgur, stripping off the v should still work as it makes Imgur convert the video to animated gif. @mxew Is there a specific circumstance that the missing v is causing a problem?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.