search

mxgross / EasyBackupBundle

Kimai 2 Plugin for easier backups
MIT License
25 stars 6 forks source link

Dump Format invalid #22

Closed plutocrat closed 4 years ago

plutocrat commented 4 years ago

Hi, The dump as produced on an Ubuntu 18 server contained the line "mysqldump: [Warning] Using a password on the command line interface can be insecure." At the top of the file, which means that when you try to restore it, it fails with a format error. Removing the line makes restoring the database possible.

Suggestion: An automated restore from the web interface would be useful. Or at least, instructions on how to extract and restore a database from a dump.

plutocrat commented 4 years ago

Also, stray .env file left in backup directory by extracting a backup, was listed as a backup called .env. Should probably limit listing to *.zip

mxgross commented 4 years ago

Hello, as long as there is no restore functionality, use this instruction: https://www.kimai.org/documentation/backups.html In the chapter "restore" is everything described.

mxgross commented 4 years ago

Hello @plutocrat, I fixed the detection for zip files in the dev branch and will be merged to master soon.

For the problem with the mysqldump warning you could do me a favor and test if the warning disappears when you add this in the file kimai2\var\plugins\EasyBackupBundle\Controller\EasyBackupController.php mysqldump_warning_prevention I forgot the square brackets around the 'Warning' in the screenshot, you may need to add them too.

| grep -v '[Warning]: Using a password'

I cannot test it myself at the moment because it does not appear in my environment.

Please tell me if this will help. Thanks, Max