mxgross / EasyBackupBundle

Kimai 2 Plugin for easier backups
MIT License
25 stars 6 forks source link

Make it compatible for FTP users #3

Closed kevinpapst closed 4 years ago

kevinpapst commented 4 years ago

(Not only) FTP users will not have the bin/console command and likely not have git as well. Deployment process does not involve GIT in every environment.

You can pull the Kimai version via PHP constants directly:

$version = \App\Constants::VERSION . ' ' . \App\Constants::STATUS;

And I'd remove the "git rev-parse HEAD" call completely or at least make sure to catch possible exceptions and write an empty string if it couldn't be fetched.