search

mxgross / EasyBackupBundle

Kimai 2 Plugin for easier backups
MIT License
24 stars 6 forks source link

Password from DATABASE_URL needs urldecode to convert % #44

Closed keestux closed 2 years ago

keestux commented 2 years ago

Hello,

The password from DATABASE_URL can contain %40 to allow a @ character in the password. This works well in Kimai, but not in EasyBackup.

How about replacing this

            $mysqlDumpCmd = str_replace('{password}', $dbPwd, $mysqlDumpCmd);

by

            $mysqlDumpCmd = str_replace('{password}', urldecode($dbPwd), $mysqlDumpCmd);
mxgross commented 2 years ago

Hi, good idea, I commited it like you suggested. Thanks