Code styles & more - Githubissues

kevinpapst commented 4 years ago

Some "housekeeping", please decide if you want some of them. I added single commits so you could cherry pick single commits if wished.

This PR includes:

an empty LICENSE file to be filled by @mxgross
configuration for php-cs-fixer
a .gitignore file for kimai bundles to simplify maintainers life
composer.json was adjusted:
- proper project name (for registration via packages if wanted)
- added scripts composer codestyle and composer codestyle-fix
- bumped version to 0.2 for the next release

All the other code changes come from running the codestyle fixer via composer codestyle-fix. This aligned the codestyle to be unified across all files.

kevinpapst commented 4 years ago

Whoops, some git magic failed. will cleanup the problems...

mxgross commented 4 years ago

Whoops, some git magic failed. will cleanup the problems...

I think it was my fault, I tried to resolve a merge conflict and it seems like I reverted the route/path changes by accident.

kevinpapst commented 4 years ago

Fixed the merge conflict. The code looks good on my end and works.

kevinpapst commented 4 years ago

Almost, after your latest push ;-) will merge again

mxgross commented 4 years ago

Thanks, I will merge it now. I will see how I can setup my Visual Studio Code to use this codestyle.

kevinpapst commented 4 years ago

I am used to this codestyle. My workflow is to use a local pre-commit hook to run composer codestyle. If this fails, I cannot push and run composer codestyle-fix manually.

mxgross / EasyBackupBundle

Code styles & more #7