search

mxgxw / MFRC522-python

A small class to interface with the NFC reader Module MFRC522
GNU Lesser General Public License v3.0
521 stars 419 forks source link

Copyright / License #5

Closed oskarpearson closed 6 years ago

oskarpearson commented 10 years ago

Hi - Thanks for a useful module.

Could I trouble you to add some indication of the license / copyright to this project?

It seems that the original Arduino code might be under Apache v2 - if this is a port of https://github.com/JoyLabs/arduino

I'm interested in using the code as part of https://github.com/oskarpearson/raspberry-pi-access-control-system but would prefer to license clarity before I do so.

Thanks!

Oskar

mxgxw commented 10 years ago

Hi Oskar!

I have tried to trace the original author of the Arduino Code without success, I suspect that it was just a proof of concept from the manufacturer, the original code even had comments in chinese, it didn't have attached any license.

I remember that I downloaded it from a blog that managed to get a backup of the code before it was deleted from the manufacturer website. But this kind of modules are manufactured in several places so it's really hard to know wich was the original author.

Let me look in my records to see if I can find something. The RPi version is a full rewrite that I made following the logic on the original source-code.

I normally release my code under GNU/GPL v2, but thanks for remind me that I still have not added a license to that repository. I would add it now.

Regards, Mario.

On Thu, May 15, 2014 at 4:48 PM, Oskar Pearson notifications@github.comwrote:

Hi - Thanks for a useful module.

Could I trouble you to add some indication of the license / copyright to this project?

It seems that the original Arduino code might be under Apache v2 - if this is a port of https://github.com/JoyLabs/arduino

I'm interested in using the code as part of https://github.com/oskarpearson/raspberry-pi-access-control-system but would prefer to license clarity before I do so.

Thanks!

Oskar

— Reply to this email directly or view it on GitHubhttps://github.com/mxgxw/MFRC522-python/issues/5 .

oskarpearson commented 10 years ago

Thanks Mario!

I thought I'd just check in here. I've got some commits that I'd like to make to the code, but would prefer to have the license nice and clear before doing so. I guess I'm a bit pedantic with that stuff.

The changes I'm going to propose make the code useable as a library, and also normalise it's formatting to PEP8. That way I can include it in another piece of code I'm writing.

Thanks for everything,

Oskar

glogiotatidis commented 9 years ago

+1 for a license. Thanks!

LudwigKnuepfer commented 6 years ago

@mxgxw ping

mxgxw commented 6 years ago

Hi all! After many years the code now includes the copyright notice and the license. In this case I have choosen the GNU LGPL 3.0. Please take this into consideration when using in your projects. Sorry for the long delay. I hope this allows you to include the code in your projects and make derivatives more easily. Regards.