search

mxhdev / SQLChecker

GNU General Public License v3.0
1 stars 1 forks source link

Callable type variable is not dynamic enough #1

Closed mxhdev closed 8 years ago

mxhdev commented 8 years ago

The SQLCallable.type variable uses hard-coded types. A better way of doing this, would be to define the following variables in the appropriate class

public static final int TYPE_FUNCTION = 0;
public static final int TYPE_PROCEDURE = 1;
public static final int TYPE_OTHER = 2;

This would also improve the general code style at this point

mxhdev commented 8 years ago

The use of "static" should also not be hard coded, but defined in a static final Variable somewhere

mxhdev commented 8 years ago

Fixed in commit c86d544e