Closed elenaf9 closed 2 years ago
@elenaf9 could you resolve the merge conflicts?
@elenaf9 should I cut a release already, or do you expect other changes in the near future?
@elenaf9 should I cut a release already, or do you expect other changes in the near future?
I am still looking into simplifying the IfWatcher
integration in rust-libp2p. There may still be some minor changes coming. I will ping you once I am through and we can cut a release. Thanks!
Make
IfWatcher::new
synchronous. The only reason why it is currently async is because thelinux
implementation executed aAddressGetRequest
innew
to obtain the initial list of ip addresses. By chaining this stream together with the existing message stream we can makelinux::IfWatcher::new
sync and instead move the polling into theStream
impl. Motivation for this change is thatIfWatcher::new
being async currently causes some complexity in rust-libp2p. Concretely, it forces to wrap theIfWatcher
in an enum [1] and first poll the future returned byIfWatcher::new
[2] before we can poll theIfWatcher
itself.