Closed mxinden closed 5 years ago
I think we will need to be explicit about Little/Big Endian and support both even though there is a "natural" choice.
Sent by mobile; please excuse my brevity.
On Wed, Jun 5, 2019, 21:02 Max Inden notifications@github.com wrote:
You can view, comment on, or merge this pull request online at: https://github.com/mxinden/modbus_exporter/pull/11 Commit Summary *: Enable configuration of Prometheus metric type File Changes M config/config.go https://github.com/mxinden/modbus_exporter/pull/11/files#diff-0 (50) M config/config_test.go https://github.com/mxinden/modbus_exporter/pull/11/files#diff-1 (15) M modbus.yml https://github.com/mxinden/modbus_exporter/pull/11/files#diff-2 (8) M modbus/metric.go https://github.com/mxinden/modbus_exporter/pull/11/files#diff-3 (13) M modbus/modbus.go https://github.com/mxinden/modbus_exporter/pull/11/files#diff-4 (51) M modbus/modbus_test.go https://github.com/mxinden/modbus_exporter/pull/11/files#diff-5 (4) Patch Links: https://github.com/mxinden/modbus_exporter/pull/11.patch https://github.com/mxinden/modbus_exporter/pull/11.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mxinden/modbus_exporter/pull/11?email_source=notifications&email_token=AAFYII5IP4ESMLIVJOL7TMLPZAETTA5CNFSM4HUD33R2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GX3EJRQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFYII6FQPQEZFX7BWNPRRDPZAETTANCNFSM4HUD33RQ .
You can view, comment on, or merge this pull request online at:
https://github.com/mxinden/modbus_exporter/pull/11 Commit Summary
File Changes
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mxinden/modbus_exporter/pull/11?email_source=notifications&email_token=AAFYII5IP4ESMLIVJOL7TMLPZAETTA5CNFSM4HUD33R2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GX3EJRQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFYII6FQPQEZFX7BWNPRRDPZAETTANCNFSM4HUD33RQ .
@RichiH for sure. This is part of the todo list on the README.md page.
I think we will need to be explicit about Little/Big Endian and support both even though there is a "natural" choice.
Sent by mobile; please excuse my brevity.
On Wed, Jun 5, 2019, 21:02 Max Inden notifications@github.com wrote: